laude

AnRil/laude

Fork 0

Commit Graph

Author	SHA1	Message	Date
AnRil	f3367e09de	chore+fix: repo hygiene, code-review fixes, audit cleanup Three independent code reviews + a security audit produced ~200 findings. This commit lands the high-impact subset. Tests pass (53), typecheck clean, eslint clean (3 minor exhaustive-deps warnings left). REPO HYGIENE - Add .editorconfig, .prettierrc.json, .prettierignore. - Add ESLint flat config (.eslintrc.cjs) — correctness-focused, no style rules (Prettier owns formatting). - Add `format` / `format:check` / `lint` npm scripts. - Add CHANGELOG.md (Keep a Changelog format, back-filled to 0.1.x). - Reformat all source via Prettier so future diffs stay small. DATA SAFETY (src/main/store.ts) - Atomic write (tmp + rename) with retry on transient EBUSY/EPERM — was non-atomic writeFileSync, vulnerable to truncation on power loss. - On corrupt JSON, rename to `app-state.json.corrupt-<ts>` instead of silently overwriting the user's exercises/history with defaults. - Validate parsed shape before merging — reject arrays/scalars where objects expected; per-field array checks. - Strip `id` from incoming patches in updateExercise/updateChallenge — a runtime caller (IPC) could otherwise smuggle id changes through. - clearHistory now refuses an unbounded wipe (no beforeTs => no-op); callers must pass an explicit boundary. - unref() the debounce timer so it doesn't keep the event loop alive. SECURITY (src/main/) - gsi-server: hard 256 KB body cap (was unbounded — local OOM vector), reject any Origin/Sec-Fetch-Site header (blocks browser CSRF from visited pages), require application/json Content-Type, generic 400 on parse error (no error string echo to client), closeAllConnections + async close on stop. - dota2: validate auth.token from payload with timingSafeEqual against the per-install token — was unauthenticated, any local process could forge match-end events. Narrow object shape before spread-merge to avoid throws on hostile payloads like {player:"x"}. Reset latest / prevState after match_end so the next match starts clean. - ipc: gate `dev:simulateMatchEnd` registration behind `!app.isPackaged` so it does not exist in shipped builds. - preload: gate the matching `simulateMatchEnd` export behind `import.meta.env.MODE !== 'production'` so the bundler dead-code- eliminates it from the production preload bundle. - windows: shell.openExternal allowlist (http/https/mailto only) — was forwarding any URL, including file:/javascript:/custom URI handlers (some Windows handlers have been RCE vectors). will-navigate blocks navigation to anywhere except file:// or the dev URL. CORRECTNESS (src/main/ + src/shared/) - shared/types.ts isQuietAt: fix wrap-around + day-of-week filter. With from=22:00 to=07:00 days=[Mon..Fri], the window started THE PREVIOUS DAY when we're in the AM half — old code checked today's day-of-week and got the wrong answer Sat 02:00 and Mon 01:00. Now the filter is evaluated against the window's START day. Also reject malformed HH:MM strings instead of producing NaN. - scheduler: call broadcastState() after firing exercises so the renderer's Dashboard/Exercises pages don't show stale nextFireAt until the next state-changing IPC. Guard powerMonitor listeners against double-registration on dev hot-reload. - dota2: fix `launchOptionStatus = steamRunning ? 'queued' : 'queued'` tautology — both branches now correctly read 'queued'. - steam-launch-options: replace `require('node:fs')` inside atomicWrite with the top-level import; retry on transient EBUSY/EPERM. CORRECTNESS (src/renderer/) - lib/history.ts: replace `today.getTime() - i * MS_DAY` arithmetic with `setDate(date - i)` calendar arithmetic in dailyRepsRange and currentStreak — DST transitions shift epoch math by ±1h and cause dayKey() to emit duplicate or missing days at the boundary. - lib/icon.tsx: restrict name lookup to ICON_CHOICES set — an arbitrary string from a corrupted state file could otherwise resolve to unrelated Lucide exports and crash the renderer. - lib/format.ts: guard formatCountdown against NaN/Infinity. - i18n/index.ts: replace regex-based interpolation with split/join so variable values containing regex metacharacters interpolate literally; warn in dev on missing keys; clamp pluralRu(-N) via abs. - ReminderApp: keyboard shortcuts moved INTO ExerciseReminder so Enter respects the stepper's `adjusted` flag (was always passing planned reps). Stepper capped at 5× planned. Don't hijack Space when a button is focused. `key={exercise.id+nextFireAt}` forces a fresh component for back-to-back reminders so stepper state resets. Match summary view gets Esc-to-close. Functional setMode in onMarkDone avoids races against stale `mode.done`. - UpdaterCard: guard against NaN/Infinity in download-progress events (electron-updater fires early events with undefined fields). - Games: gate DevPanel behind `import.meta.env.DEV` in addition to the main-side IPC gate, and narrow the `simulateMatchEnd` access. - Add aria-labels for the +/- stepper buttons (i18n keys added). TESTS - +2 quiet-hours tests covering wrap-around + day-filter combo and malformed HH:MM fallback. Total 53 passing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-18 23:04:49 +07:00
AnRil	d6f94ee1c9	docs+chore: retry upload on TLS/504 + refresh README/RELEASING Upload script: - Retry curl on transient network failures (504, schannel TLS abrupt close): up to 4 retries with 15s/45s/2m/5m backoff. Before each retry, list the release assets server-side — Gitea sometimes commits the body but times out the response, so the file may already be there at the expected size (skip retry). If present at wrong size (partial), delete before re-uploading. ASCII-only (PS5.1 reads files in CP1251 without BOM). Docs: - README: bump release/test badges to v0.5.1 / 51 tests; mention silent retry in the auto-update feature line. - RELEASING: rewrite around the new update-channel architecture, bridge tags, and dropped Gitea Actions workflows. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-18 22:37:33 +07:00
AnRil	92e15e69a3	feat: auto-update, тесты и CI/CD Some checks failed CI / Typecheck + Tests (push) Has been cancelled Details CI / Build (Windows) (push) Has been cancelled Details Полная автоматизация релизного цикла. == Auto-update (electron-updater) == - src/main/updater.ts — обёртка над autoUpdater с дискриминированным UpdaterStatus union и broadcast через IPC. autoDownload=false, пользователь сам жмёт «Скачать». allowDowngrade=false. Проверка каждые 6 часов, первая через 5с после старта. - В dev-режиме (app.isPackaged=false) статус сразу становится 'unsupported' с пояснением — никаких exceptions из updater'а. - build.publish в package.json: provider=generic, url указывает на Gitea release assets конкретной версии. - src/main/ipc.ts: 4 новых канала — status/check/download/install. - src/preload: API window.api.updater* + onUpdaterStatus. - src/renderer/src/components/UpdaterCard.tsx: HUD-карточка в Settings с состояниями idle/checking/available/downloading/downloaded/error, прогресс-бар с скоростью в МБ/с. == Тесты (vitest) == - vitest.config.ts с алиасами @shared / @renderer - 23 теста, все зелёные: * format.test.ts — formatCountdown, formatInterval (8 cases) * vdf.test.ts — parseVdf / stringifyVdf / round-trip (11 cases) * types.test.ts — DEFAULT_SETTINGS, SAMPLE_EXERCISES sanity (4) - npm scripts: test (watch), test:run (CI) == CI/CD (Gitea Actions) == - .gitea/workflows/ci.yml — на push/PR: typecheck + тесты + smoke-сборка - .gitea/workflows/release.yml — на тег v..*: сборка NSIS + Gitea release == Локальный релизный скрипт == - scripts/release.ps1 — один скрипт от бампа версии до публикации через Gitea API (params: -Bump patch/minor/major, -Version, -DryRun) - npm run release — обёртка - RELEASING.md — полная инструкция Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-16 20:32:59 +07:00

Author

SHA1

Message

Date

AnRil

f3367e09de

chore+fix: repo hygiene, code-review fixes, audit cleanup

Three independent code reviews + a security audit produced ~200 findings.
This commit lands the high-impact subset. Tests pass (53), typecheck
clean, eslint clean (3 minor exhaustive-deps warnings left).

REPO HYGIENE
- Add .editorconfig, .prettierrc.json, .prettierignore.
- Add ESLint flat config (.eslintrc.cjs) — correctness-focused, no style
  rules (Prettier owns formatting).
- Add `format` / `format:check` / `lint` npm scripts.
- Add CHANGELOG.md (Keep a Changelog format, back-filled to 0.1.x).
- Reformat all source via Prettier so future diffs stay small.

DATA SAFETY (src/main/store.ts)
- Atomic write (tmp + rename) with retry on transient EBUSY/EPERM —
  was non-atomic writeFileSync, vulnerable to truncation on power loss.
- On corrupt JSON, rename to `app-state.json.corrupt-<ts>` instead of
  silently overwriting the user's exercises/history with defaults.
- Validate parsed shape before merging — reject arrays/scalars where
  objects expected; per-field array checks.
- Strip `id` from incoming patches in updateExercise/updateChallenge —
  a runtime caller (IPC) could otherwise smuggle id changes through.
- clearHistory now refuses an unbounded wipe (no beforeTs => no-op);
  callers must pass an explicit boundary.
- unref() the debounce timer so it doesn't keep the event loop alive.

SECURITY (src/main/*)
- gsi-server: hard 256 KB body cap (was unbounded — local OOM vector),
  reject any Origin/Sec-Fetch-Site header (blocks browser CSRF from
  visited pages), require application/json Content-Type, generic 400
  on parse error (no error string echo to client), closeAllConnections
  + async close on stop.
- dota2: validate auth.token from payload with timingSafeEqual against
  the per-install token — was unauthenticated, any local process could
  forge match-end events. Narrow object shape before spread-merge to
  avoid throws on hostile payloads like {player:"x"}. Reset latest /
  prevState after match_end so the next match starts clean.
- ipc: gate `dev:simulateMatchEnd` registration behind `!app.isPackaged`
  so it does not exist in shipped builds.
- preload: gate the matching `simulateMatchEnd` export behind
  `import.meta.env.MODE !== 'production'` so the bundler dead-code-
  eliminates it from the production preload bundle.
- windows: shell.openExternal allowlist (http/https/mailto only) — was
  forwarding any URL, including file:/javascript:/custom URI handlers
  (some Windows handlers have been RCE vectors). will-navigate blocks
  navigation to anywhere except file:// or the dev URL.

CORRECTNESS (src/main/* + src/shared/*)
- shared/types.ts isQuietAt: fix wrap-around + day-of-week filter.
  With from=22:00 to=07:00 days=[Mon..Fri], the window started THE
  PREVIOUS DAY when we're in the AM half — old code checked today's
  day-of-week and got the wrong answer Sat 02:00 and Mon 01:00. Now
  the filter is evaluated against the window's START day. Also reject
  malformed HH:MM strings instead of producing NaN.
- scheduler: call broadcastState() after firing exercises so the
  renderer's Dashboard/Exercises pages don't show stale nextFireAt
  until the next state-changing IPC. Guard powerMonitor listeners
  against double-registration on dev hot-reload.
- dota2: fix `launchOptionStatus = steamRunning ? 'queued' : 'queued'`
  tautology — both branches now correctly read 'queued'.
- steam-launch-options: replace `require('node:fs')` inside atomicWrite
  with the top-level import; retry on transient EBUSY/EPERM.

CORRECTNESS (src/renderer/*)
- lib/history.ts: replace `today.getTime() - i * MS_DAY` arithmetic
  with `setDate(date - i)` calendar arithmetic in dailyRepsRange and
  currentStreak — DST transitions shift epoch math by ±1h and cause
  dayKey() to emit duplicate or missing days at the boundary.
- lib/icon.tsx: restrict name lookup to ICON_CHOICES set — an arbitrary
  string from a corrupted state file could otherwise resolve to
  unrelated Lucide exports and crash the renderer.
- lib/format.ts: guard formatCountdown against NaN/Infinity.
- i18n/index.ts: replace regex-based interpolation with split/join so
  variable values containing regex metacharacters interpolate
  literally; warn in dev on missing keys; clamp pluralRu(-N) via abs.
- ReminderApp: keyboard shortcuts moved INTO ExerciseReminder so Enter
  respects the stepper's `adjusted` flag (was always passing planned
  reps). Stepper capped at 5× planned. Don't hijack Space when a
  button is focused. `key={exercise.id+nextFireAt}` forces a fresh
  component for back-to-back reminders so stepper state resets. Match
  summary view gets Esc-to-close. Functional setMode in onMarkDone
  avoids races against stale `mode.done`.
- UpdaterCard: guard against NaN/Infinity in download-progress events
  (electron-updater fires early events with undefined fields).
- Games: gate DevPanel behind `import.meta.env.DEV` in addition to the
  main-side IPC gate, and narrow the `simulateMatchEnd` access.
- Add aria-labels for the +/- stepper buttons (i18n keys added).

TESTS
- +2 quiet-hours tests covering wrap-around + day-filter combo and
  malformed HH:MM fallback. Total 53 passing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-18 23:04:49 +07:00

AnRil

d6f94ee1c9

docs+chore: retry upload on TLS/504 + refresh README/RELEASING

Upload script:
- Retry curl on transient network failures (504, schannel TLS abrupt
  close): up to 4 retries with 15s/45s/2m/5m backoff. Before each retry,
  list the release assets server-side — Gitea sometimes commits the
  body but times out the response, so the file may already be there at
  the expected size (skip retry). If present at wrong size (partial),
  delete before re-uploading. ASCII-only (PS5.1 reads files in CP1251
  without BOM).

Docs:
- README: bump release/test badges to v0.5.1 / 51 tests; mention silent
  retry in the auto-update feature line.
- RELEASING: rewrite around the new update-channel architecture, bridge
  tags, and dropped Gitea Actions workflows.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-18 22:37:33 +07:00

AnRil

92e15e69a3

feat: auto-update, тесты и CI/CD

CI / Typecheck + Tests (push) Has been cancelled

Details

CI / Build (Windows) (push) Has been cancelled

Details

Полная автоматизация релизного цикла.

== Auto-update (electron-updater) ==
- src/main/updater.ts — обёртка над autoUpdater с дискриминированным
  UpdaterStatus union и broadcast через IPC. autoDownload=false,
  пользователь сам жмёт «Скачать». allowDowngrade=false. Проверка
  каждые 6 часов, первая через 5с после старта.
- В dev-режиме (app.isPackaged=false) статус сразу становится
  'unsupported' с пояснением — никаких exceptions из updater'а.
- build.publish в package.json: provider=generic, url указывает на
  Gitea release assets конкретной версии.
- src/main/ipc.ts: 4 новых канала — status/check/download/install.
- src/preload: API window.api.updater* + onUpdaterStatus.
- src/renderer/src/components/UpdaterCard.tsx: HUD-карточка в Settings
  с состояниями idle/checking/available/downloading/downloaded/error,
  прогресс-бар с скоростью в МБ/с.

== Тесты (vitest) ==
- vitest.config.ts с алиасами @shared / @renderer
- 23 теста, все зелёные:
  * format.test.ts — formatCountdown, formatInterval (8 cases)
  * vdf.test.ts — parseVdf / stringifyVdf / round-trip (11 cases)
  * types.test.ts — DEFAULT_SETTINGS, SAMPLE_EXERCISES sanity (4)
- npm scripts: test (watch), test:run (CI)

== CI/CD (Gitea Actions) ==
- .gitea/workflows/ci.yml — на push/PR: typecheck + тесты + smoke-сборка
- .gitea/workflows/release.yml — на тег v*.*.*: сборка NSIS + Gitea release

== Локальный релизный скрипт ==
- scripts/release.ps1 — один скрипт от бампа версии до публикации
  через Gitea API (params: -Bump patch/minor/major, -Version, -DryRun)
- npm run release — обёртка
- RELEASING.md — полная инструкция

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-16 20:32:59 +07:00

3 Commits