chore+fix: repo hygiene, code-review fixes, audit cleanup
Three independent code reviews + a security audit produced ~200 findings.
This commit lands the high-impact subset. Tests pass (53), typecheck
clean, eslint clean (3 minor exhaustive-deps warnings left).
REPO HYGIENE
- Add .editorconfig, .prettierrc.json, .prettierignore.
- Add ESLint flat config (.eslintrc.cjs) — correctness-focused, no style
rules (Prettier owns formatting).
- Add `format` / `format:check` / `lint` npm scripts.
- Add CHANGELOG.md (Keep a Changelog format, back-filled to 0.1.x).
- Reformat all source via Prettier so future diffs stay small.
DATA SAFETY (src/main/store.ts)
- Atomic write (tmp + rename) with retry on transient EBUSY/EPERM —
was non-atomic writeFileSync, vulnerable to truncation on power loss.
- On corrupt JSON, rename to `app-state.json.corrupt-<ts>` instead of
silently overwriting the user's exercises/history with defaults.
- Validate parsed shape before merging — reject arrays/scalars where
objects expected; per-field array checks.
- Strip `id` from incoming patches in updateExercise/updateChallenge —
a runtime caller (IPC) could otherwise smuggle id changes through.
- clearHistory now refuses an unbounded wipe (no beforeTs => no-op);
callers must pass an explicit boundary.
- unref() the debounce timer so it doesn't keep the event loop alive.
SECURITY (src/main/*)
- gsi-server: hard 256 KB body cap (was unbounded — local OOM vector),
reject any Origin/Sec-Fetch-Site header (blocks browser CSRF from
visited pages), require application/json Content-Type, generic 400
on parse error (no error string echo to client), closeAllConnections
+ async close on stop.
- dota2: validate auth.token from payload with timingSafeEqual against
the per-install token — was unauthenticated, any local process could
forge match-end events. Narrow object shape before spread-merge to
avoid throws on hostile payloads like {player:"x"}. Reset latest /
prevState after match_end so the next match starts clean.
- ipc: gate `dev:simulateMatchEnd` registration behind `!app.isPackaged`
so it does not exist in shipped builds.
- preload: gate the matching `simulateMatchEnd` export behind
`import.meta.env.MODE !== 'production'` so the bundler dead-code-
eliminates it from the production preload bundle.
- windows: shell.openExternal allowlist (http/https/mailto only) — was
forwarding any URL, including file:/javascript:/custom URI handlers
(some Windows handlers have been RCE vectors). will-navigate blocks
navigation to anywhere except file:// or the dev URL.
CORRECTNESS (src/main/* + src/shared/*)
- shared/types.ts isQuietAt: fix wrap-around + day-of-week filter.
With from=22:00 to=07:00 days=[Mon..Fri], the window started THE
PREVIOUS DAY when we're in the AM half — old code checked today's
day-of-week and got the wrong answer Sat 02:00 and Mon 01:00. Now
the filter is evaluated against the window's START day. Also reject
malformed HH:MM strings instead of producing NaN.
- scheduler: call broadcastState() after firing exercises so the
renderer's Dashboard/Exercises pages don't show stale nextFireAt
until the next state-changing IPC. Guard powerMonitor listeners
against double-registration on dev hot-reload.
- dota2: fix `launchOptionStatus = steamRunning ? 'queued' : 'queued'`
tautology — both branches now correctly read 'queued'.
- steam-launch-options: replace `require('node:fs')` inside atomicWrite
with the top-level import; retry on transient EBUSY/EPERM.
CORRECTNESS (src/renderer/*)
- lib/history.ts: replace `today.getTime() - i * MS_DAY` arithmetic
with `setDate(date - i)` calendar arithmetic in dailyRepsRange and
currentStreak — DST transitions shift epoch math by ±1h and cause
dayKey() to emit duplicate or missing days at the boundary.
- lib/icon.tsx: restrict name lookup to ICON_CHOICES set — an arbitrary
string from a corrupted state file could otherwise resolve to
unrelated Lucide exports and crash the renderer.
- lib/format.ts: guard formatCountdown against NaN/Infinity.
- i18n/index.ts: replace regex-based interpolation with split/join so
variable values containing regex metacharacters interpolate
literally; warn in dev on missing keys; clamp pluralRu(-N) via abs.
- ReminderApp: keyboard shortcuts moved INTO ExerciseReminder so Enter
respects the stepper's `adjusted` flag (was always passing planned
reps). Stepper capped at 5× planned. Don't hijack Space when a
button is focused. `key={exercise.id+nextFireAt}` forces a fresh
component for back-to-back reminders so stepper state resets. Match
summary view gets Esc-to-close. Functional setMode in onMarkDone
avoids races against stale `mode.done`.
- UpdaterCard: guard against NaN/Infinity in download-progress events
(electron-updater fires early events with undefined fields).
- Games: gate DevPanel behind `import.meta.env.DEV` in addition to the
main-side IPC gate, and narrow the `simulateMatchEnd` access.
- Add aria-labels for the +/- stepper buttons (i18n keys added).
TESTS
- +2 quiet-hours tests covering wrap-around + day-filter combo and
malformed HH:MM fallback. Total 53 passing.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
AnRil
96
CHANGELOG.md
Normal file
96
CHANGELOG.md
Normal file
@@ -0,0 +1,96 @@
|
||||
# Changelog
|
||||
|
||||
Все заметные изменения проекта документируются здесь.
|
||||
Формат основан на [Keep a Changelog](https://keepachangelog.com/ru/1.1.0/),
|
||||
проект следует [Semantic Versioning](https://semver.org/lang/ru/).
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Added
|
||||
|
||||
- Prettier + ESLint конфиги, скрипты `npm run format` / `npm run lint`.
|
||||
- `.editorconfig` для единообразного оформления между редакторами.
|
||||
|
||||
## [0.5.1] — 2026-05-18
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Auto-update архитектурно переписан.** Раньше `publish.url` включал
|
||||
`${version}` и запекался в каждый билд — установленные копии видели
|
||||
только свой собственный релиз. Введён фиксированный
|
||||
`…/releases/download/update-channel`, который никогда не меняется.
|
||||
- Hourly auto-проверка работает в silent-режиме: транзитные сетевые
|
||||
ошибки (504, TLS drops) больше не показывают красный баннер
|
||||
«Ошибка проверки». Только ручной клик «Проверить» поднимает ошибку.
|
||||
- Boot-check ретраит 3 раза с backoff 30s/2m/5m.
|
||||
- В `Up to date` показывается «проверено N мин назад».
|
||||
- `release.ps1` теперь публикует в три-четыре места одной командой:
|
||||
vX.Y.Z, update-channel, и переданные `-BridgeTags` для миграции
|
||||
пользователей со старых версий.
|
||||
- `upload-release-assets.ps1` ретраит curl до 4 раз с backoff на 504 /
|
||||
TLS-сбрасывание; до ретрая проверяет, не залился ли файл на самом
|
||||
деле (Gitea часто принимает body, но таймаутит ответ).
|
||||
- Скрипты — ASCII-only (PS5.1 без BOM падает на em-dash).
|
||||
|
||||
### Removed
|
||||
|
||||
- `.gitea/workflows/*.yml` — Gitea Actions без настроенных runners
|
||||
оставляли queued runs в репозитории. Релизим через `release.ps1`.
|
||||
|
||||
## [0.5.0] — 2026-05-18
|
||||
|
||||
### Added
|
||||
|
||||
- **История + стрики.** Каждое выполненное упражнение пишется в
|
||||
`app-state.json` (cap 10k записей, trim oldest 10% на overflow).
|
||||
Heatmap-календарь 12 недель на Dashboard, ежедневный счётчик
|
||||
«сделано сегодня», серия дней подряд (с grace-периодом за вчера).
|
||||
- **Тихие часы.** Окно времени, в которое напоминания подавляются.
|
||||
Поддержка wrap-around (22:00 → 08:00) и фильтра по дням недели.
|
||||
- **Частичное выполнение.** Степпер `−/+` в окне напоминания: можно
|
||||
отметить «сделал 5 из 10», в историю запишется честное число.
|
||||
- README.md на русском — описание, фичи, установка, dev-команды,
|
||||
архитектура, стек.
|
||||
|
||||
### Changed
|
||||
|
||||
- `markDone(id, actualReps?)` принимает фактическое число повторений.
|
||||
|
||||
### Tests
|
||||
|
||||
- `+18` тестов (5 для тихих часов, 13 для истории/стриков). Всего 51.
|
||||
|
||||
## [0.4.0] — 2026-05-17
|
||||
|
||||
### Added
|
||||
|
||||
- **Английская локализация.** Самописная i18n: плоский словарь
|
||||
~200 ключей × 2 языка + хук `useT()` + плюрализация (CLDR rules
|
||||
для RU: one/few/many).
|
||||
- Селектор языка в Settings, переключение мгновенное.
|
||||
|
||||
## [0.3.x] — 2026-05-17
|
||||
|
||||
Серия мелких релизов с дизайн-итерациями (Apple iOS / macOS aesthetic):
|
||||
шрифты Plus Jakarta Sans + Bricolage Grotesque, светлая/тёмная/системная
|
||||
тема, vibrancy sidebar, iOS-grouped lists, spring-анимации.
|
||||
|
||||
## [0.2.0] — 2026-05-16
|
||||
|
||||
### Added
|
||||
|
||||
- Dota 2 Game State Integration: локальный HTTP-сервер парсит callbacks
|
||||
от Steam, после Победа/Поражение показывает «причитающиеся»
|
||||
повторения (например `10 смертей × 3 = 30 приседаний`).
|
||||
|
||||
## [0.1.x] — 2026-05-15 .. 2026-05-16
|
||||
|
||||
Первые публичные сборки: ядро напоминаний (упражнения, интервалы,
|
||||
иконки), системный трей, автозапуск с Windows, native-уведомления,
|
||||
NSIS-инсталлятор, auto-update через electron-updater.
|
||||
|
||||
[Unreleased]: https://xn--90adajar8af4h.xn--p1ai/git/AnRil/laude/compare/v0.5.1...HEAD
|
||||
[0.5.1]: https://xn--90adajar8af4h.xn--p1ai/git/AnRil/laude/releases/tag/v0.5.1
|
||||
[0.5.0]: https://xn--90adajar8af4h.xn--p1ai/git/AnRil/laude/releases/tag/v0.5.0
|
||||
[0.4.0]: https://xn--90adajar8af4h.xn--p1ai/git/AnRil/laude/releases/tag/v0.4.0
|
||||
[0.2.0]: https://xn--90adajar8af4h.xn--p1ai/git/AnRil/laude/releases/tag/v0.2.0
|
||||
Reference in New Issue
Block a user